node: add keyprint command #4185
Draft
+53
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pleasew8t
requested review from
bruce-riley,
panoel and
evan-gray
as code owners
|
Does this open a new security hole where anyone with access to a guardian box can print the private key? |
andreclaro
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
keyprintcommand, which unmarshals a guardian-generated key file and prints out the private key as a hex string. With KMS incoming (along with other potential signing mechanisms) it might be desirable to reuse/import an existing key into the key management solution.Usage:
guardiand keyprint <path-to-keyfile>